Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixed splash screen crash when bringing Android app back to foreground after being evicted from memory. (#47635)#16916

Merged
matthew-carroll merged 1 commit into
flutter-team-archive:masterfrom
matthew-carroll:bugfix-47635_fix-splash-screen-crash-on-app-from-background
Mar 4, 2020
Merged

Fixed splash screen crash when bringing Android app back to foreground after being evicted from memory. (#47635)#16916
matthew-carroll merged 1 commit into
flutter-team-archive:masterfrom
matthew-carroll:bugfix-47635_fix-splash-screen-crash-on-app-from-background

Conversation

@matthew-carroll

Copy link
Copy Markdown
Contributor

Fixed splash screen crash when bringing Android app back to foreground after being evicted from memory. (#47635)

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@matthew-carroll

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 3, 2020
@matthew-carroll

Copy link
Copy Markdown
Contributor Author

@tvolkert do you have any ideas for tests for this? I'm not aware of an available approach...

@xster

xster commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

Great, thanks for the fix Matt

LGTM

@matthew-carroll

Copy link
Copy Markdown
Contributor Author

@xster do you know if this "Mac Web Engine" failure is real or fake? Also, any thoughts on tests for this?

@tvolkert

tvolkert commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

I'm not sure how you'd test this...

@tvolkert

tvolkert commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

@ferhatb for the web test failure - this or certainly shouldn't affect that test

@blasten blasten left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatb

ferhatb commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

@ferhatb for the web test failure - this or certainly shouldn't affect that test

Cacoon was out of sync with web directory. Issue is resolved.

@matthew-carroll

Copy link
Copy Markdown
Contributor Author

Ok, I'm gonna merge this without tests, and ignoring the web failure based on @ferhatb's comment.

@matthew-carroll matthew-carroll merged commit 482155b into flutter-team-archive:master Mar 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2020
@VagnerWillian

Copy link
Copy Markdown

This correction has on the stable channel from 1.17.5 ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

7 participants